4.1 KNIME community build issues

G’morning

It would appear the CDK 4.1 branch is failing to build due to the testing dependency. This is also affecting upstream builds (Lhasa 4.1 and knime-update-4.1).

Cannot complete the install because one or more required items could not be found.
Software being installed: CDK Testing feature 1.5.200.v201711101057 (org.openscience.cdk.knime.testing.feature.feature.group 1.5.200.v201711101057)
Missing requirement: CDK Testing feature 1.5.200.v201711101057 (org.openscience.cdk.knime.testing.feature.feature.group 1.5.200.v201711101057) requires ‘org.knime.features.testingapplication.feature.group 2.7.0’ but it could not be found
Application failed, log file location: /var/lib/jenkins/jobs/org.lhasalimited.knime.update-4.1/workspace/nodes4knime/build/org.knime.community.build.config/director/configuration/1588150444605.log

The last commit on the 4.0 CDK branch was 9 months ago, it looks like the commit removing the dependency causing the issue was only applied to the master branch?

Does the change on the master branch need to be merged into releases/4.0?

I’ve made a pull request https://github.com/cdk/nodes4knime/pull/13 so hopefully when that gets merged it will be fixed. @gab1one does this sound about right?

Cheers

Sam

1 Like

Hi @swebb,

thanks for finding this out and creating the PR, there are no changes required for the 4.0 branch as the change to the name of the testing feature was made for the 4.1 release.

best,
Gabriel

The jenkins job for 4.1 uses the 4.0 branch though so sounds like a new release branch should have been created that this change should be merged into.

1 Like

There is a new release branch, it was not used by the 4.1 jenkins job. I changed that, now 4.1 uses this branch:

best,
Gabriel

1 Like