Bug: Change in node not applied

KNIME Analytics Platform
1

Very common issue: You have a workflow with longer execution time (let’s assue 5 minutes). While running this workflow, you check something and find a misconfiguration, e.g. in a Joiner node which was already executed (= green light). You correct this, apply and leave with “OK”.
In such cases, the change is not applied as the workflow is executed. But there is also no message saying exactly this when leaving. So the change is lost and in worse case the user is saving the workflow or pushes it to productiong while thinking the issue is solved.

How you could avoid it:

  • Disable the “OK” button as it is not allowed in this situation and error-prone (= avoid the error root-case)
  • Only if above is not possibel: Post an hint / message if the user pushes the OK button in such cases (= do not avoid the root-cause but at least gibes the user a chance)
1 Like
2

Hi @McReady,

Normally in the sitation you are referring, a warning message will be shown like this:

image

So you can stop the executing node and apply the changes, this will bring the updated node back to configure state.

Best,
Keerthan

3

Thank you @k10shetty1.
I tested it with JOINer and Row Filter, both did not show this message while “String Manipulation” does. Maybe it depends on modern vs classic styled nodes? I use the classic UI but Row Filter is already forced to the new UI (JOINer isn’t, I know).

Best

4

Hi @McReady,

I was able to reproduce this with row filter, but the value was not saved and no warning message showed as well.

I will forward this to the concerned team.

Best,
Keerthan

2 Likes
5

Hi @McReady,

Just to clarify — this behavior is already blocked in the embedded configuration dialog (shown in the right panel of the modern UI), where applying changes is not allowed while successor nodes are running.

However, in detached dialogs, it’s still possible to click “OK” even though the settings aren’t saved. Starting with version 5.5, the dialog will no longer close in this case, which helps prevent silent loss of changes.

Best,
Keerthan

2 Likes
6

Looking forward to v5.5 :smiley: Thanks for your effort Keerthan @k10shetty1

1 Like