Fingerprints expander node

#1

Hi

I believe there is a bug in the Fingerprints Expander node.

Assuming Bit 1 is the first bit in the BitVector (bit 0) then the fingerprints are being reversed as they are expanded. 

I don't appear to be able to access the source code in the latest SDK but from memory of an old version I believe you are parsing a BitStringrepresentation of the BitVector (which KNIME gives in a big endian way and is thus the reverse of the fingerprint in the little endian way which is output). 

Found the new source: https://community.knime.org/svn/nodes4knime/trunk/org.erlwood/org.erlwood.knime.core/src/org/erlwood/knime/nodes/bitvectortobits/BitVectorToBitsNodeModel.java 

Maybe I'm missing something but this looks like it is traversing in the wrong direction...?

Example:

BitString: 10000000110

Set Bits: {length=11, set bits=1, 2, 10}

Expected columns

Bit 0 Bit 1 Bit 1 Bit 3 Bit 4 Bit 5 Bit 6 Bit 7 Bit 8 Bit 9 Bit 10
0 1 1 0 0 0 0 0 0 0 1

What I get:

Bit 1 Bit 2 Bit 3 Bit 4 Bit 5 Bit 6 Bit 7 Bit 8 Bit 9 Bit 10 Bit 11
1 0 0 0 0 0 0 0 1 1 0
 

Cheers

Sam

 

0 Likes